Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: low-Mach correction for HLLC solver #80

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Conversation

BenWibking
Copy link
Contributor

New version of #57.

@BenWibking
Copy link
Contributor Author

@pgrete @forrestglines I'd like to get this merged in, so I can run my precipitator simulations with upstream AthenaPK and Parthenon. Please let me know what you need from me to do this.

@pgrete
Copy link
Contributor

pgrete commented Jan 29, 2024

This is not the full implementation of the LHLLC solver, i.e., it just contains the fix for the pressure at the contact surface and not the shock fix (based on the velocity divergence), isn't it?

@BenWibking BenWibking changed the title WIP: low-Mach HLLC solver WIP: low-Mach correction for HLLC solver Jan 29, 2024
@BenWibking
Copy link
Contributor Author

This is not the full implementation of the LHLLC solver, i.e., it just contains the fix for the pressure at the contact surface and not the shock fix (based on the velocity divergence), isn't it?

Yes, that's right.

@BenWibking BenWibking mentioned this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants