Adding the Huawei/Honor version of the Pinyin-top font #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -10,7 +10,7 @@ hosting [fonts releases](https://github.com/parlr/hanzi-pinyin-font/releases) | | |||
|
|
|||
| | ruby position-direction | preview | state | comments | |||
| | --- | :---: | :---: | --- | | |||
| | top |  | **✔** | [TTF](Hanzi-Pinyin-Font.top.ttf), [WOFF2](Hanzi-Pinyin-Font.top.woff2) | |||
| | top |  | **✔** | [TTF](Hanzi-Pinyin-Font.top.ttf), [WOFF2](Hanzi-Pinyin-Font.top.woff2), [HWT](Hanzi-Pinyin-Font.top.hwt) | |||
There was a problem hiding this comment.
Thanks for the effort!
What is the base font you used? Does its license allow for modification?
I'm using open-source fonts as proprietary fonts might not allow such use.
|
I straight up used your ttf!
…On Sat, Jan 11, 2025, 20:01 Édouard Lopez ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In README.md
<#1 (comment)>
:
> @@ -10,7 +10,7 @@ hosting [fonts releases](https://github.com/parlr/hanzi-pinyin-font/releases) |
| ruby position-direction | preview | state | comments
| --- | :---: | :---: | --- |
-| top |  | **✔** | [TTF](Hanzi-Pinyin-Font.top.ttf), [WOFF2](Hanzi-Pinyin-Font.top.woff2)
+| top |  | **✔** | [TTF](Hanzi-Pinyin-Font.top.ttf), [WOFF2](Hanzi-Pinyin-Font.top.woff2), [HWT](Hanzi-Pinyin-Font.top.hwt)
Thanks for the effort!
What is the base font you used? Does its license allow for modification?
I'm using open-source fonts
<https://github.com/parlr/ruby-font-creator?tab=readme-ov-file#font> as
proprietary fonts might not allow such use.
—
Reply to this email directly, view it on GitHub
<#1 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABHKL2FJ6HXIQOUTL3JBK3T2KEBYBAVCNFSM6AAAAABUQEIGZCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKNBUGY3DCMBWGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
So we should be fine license wise :) (bump in case you missed my reply!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.