Expose LevelizeObserver / StaLevelizeObserver + add Sta::setLevelizeObserver#433
Open
dsengupta0628 wants to merge 1 commit into
Open
Expose LevelizeObserver / StaLevelizeObserver + add Sta::setLevelizeObserver#433dsengupta0628 wants to merge 1 commit into
dsengupta0628 wants to merge 1 commit into
Conversation
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three small additions to let downstream consumers (OpenROAD's
dbSta) attachtheir own
LevelizeObserverwithout:StaLevelizeObserver's Search + GraphDelayCalc forwarding(silent drift risk if this class gains new responsibilities upstream),
levelize_member,search/Levelize.hhheader.Changes
include/sta/LevelizeObserver.hh— holdsLevelizeObserver(abstract) andStaLevelizeObserver(default impl thatforwards level-change events to
SearchandGraphDelayCalc). Both classesmoved from their previous private locations.
search/Levelize.hh— drop the inlineLevelizeObserverdefinition;include the new public header instead.
search/Sta.cc— drop the file-localStaLevelizeObserverclass body;keep its method definitions (now defining the public class).
include/sta/Sta.hh— add publicvoid Sta::setLevelizeObserver(LevelizeObserver *).search/Sta.cc— implementSta::setLevelizeObserveras a one-lineforward to
levelize_->setObserver(observer).No behavior change.
Sta::makeObserversstill installsStaLevelizeObserverexactly as before.
Why
OpenROAD
dbStaneeds to:LevelizeObserverto invalidate its driver-vertex cache whenlevels change, and
StaLevelizeObserverprovides.
Today the only way is to:
${OPENSTA_HOME}to its private include path (sincesearch/Levelize.hhisn't public),
Sta::levelize_directly,StaLevelizeObserverinto a dbSta-local subclass (driftrisk if upstream ever changes
StaLevelizeObserver).