Use fully qualified ::sta::float_inf - Tcl9 lookup changed.#424
Closed
hzeller wants to merge 1 commit into
Closed
Conversation
To get the value of a global variable, it seems in Tcl9, this requires to fully qualify it with leading `::`. While at it, make `float_inf` readonly, as it certainly is not meant to be modified. Thanks to @mikesinouye for spotting the problem. Fixes: parallaxsw#422 Signed-off-by: Henner Zeller <h.zeller@acm.org>
Contributor
Author
|
With that, the example from #422 works with both, tcl-8 and tcl-9 |
Collaborator
|
I added variable commands to import the variables instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To get the value of a global variable, it seems in Tcl9, this requires to fully qualify it with leading
::.While at it, make
float_infreadonly, as it certainly is not meant to be modified.Thanks to @mikesinouye for spotting the problem.
Fixes: #422