Fix coverity issues#420
Closed
dsengupta0628 wants to merge 2 commits into
Closed
Conversation
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
Contributor
Author
|
Should address the issue #417 |
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
Owner
|
When I made the switch to std::string I did a bunch of research and went back and forth, but in the end I converged on mostly using std::string_view for args and not inserting std::move's all over the place. I cannot run coverity (it takes them something like 6 days to approve a request), but I pushed some changes that are an alternative to some of these changes. |
Contributor
Author
|
Yes majority of these are the std::move related and thanks for fixing changes in these two files. I will merge them and reupload with whatever is remaining (currently as expected I have some merge conflicts anyways). |
Contributor
Author
|
Most have been taken care of. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes- all Coverity complaints so far. I will monitor for more too. Thanks!