Bias pin handling#409
Merged
Merged
Conversation
… write_verilog Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
Collaborator
|
Let's start with the name; I think these would be more appropriately called "well" supplies than "bias". |
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
Contributor
Author
Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds explicit bias-pin classification to OpenSTA by introducing PortDirection::bias() and mapping Liberty nwell/pwell/deepnwell/deeppwell pg pins to it. By including bias in isPowerGround(), bias pins are now treated like power/ground in existing STA and Verilog-writer filtering paths, fixing cases where write_verilog incorrectly emitted bias pins as signal pins.
A new regression was added in test/verilog_bias_pins.* using the existing examples/sky130hd_tt.lib.gz library to cover both default write_verilog behavior and write_verilog -include_pwr_gnd, with goldens updated to match the current binary output.
(Reference: https://dl.acm.org/doi/pdf/10.1145/2333660.2333679 typical bias pin handling is needed for body bias calculations and not really in timing graph just like the power/ground pins)