Add a less operator to BddPortVarMap #258
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdd_port_var_map_, of type BddPortVarMap, is iterated over in Power::evalBddActivity. Previously the map used pointer comparison so the iteration order was non-deterministic. The computed density was therefore non-deterministic due to the non-associativity of floating-point addition. Signed-off-by: Matt Liberty <[email protected]>
openroad-ci
pushed a commit
to The-OpenROAD-Project-staging/OpenROAD
that referenced
this pull request
Jun 14, 2025
Until parallaxsw/OpenSTA#258 is merged and OR updated. Signed-off-by: Matt Liberty <[email protected]>
maliberty
added a commit
to The-OpenROAD-Project/OpenSTA
that referenced
this pull request
Jun 15, 2025
Anticipating the merge to the upstream and trying to stabilize the OR CI. Signed-off-by: Matt Liberty <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bdd_port_var_map_, of type BddPortVarMap, is iterated over in Power::evalBddActivity. Previously the map used pointer comparison so the iteration order was non-deterministic. The computed density was therefore non-deterministic due to the non-associativity of floating-point addition.