Skip to content

feat: ignore fake/nonsense prerelease info from tss version #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mcr
Copy link

@mcr mcr commented May 30, 2025

when building against a libtss from source code, the git tree is sometimes dirty, and so libtss puts that info into the VERSION file.
But, it's not exactly a correct prerelease SemVer string.... so just blank that part before comparing to required version.

Copy link
Collaborator

@Superhepper Superhepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR.
Yes this seems reasonable. I wonder if it would be possible to issue a warning or an info message that the version seems to indicate a non officiell release.

@wiktor-k
Copy link
Collaborator

wiktor-k commented Jun 1, 2025

Aaah, so without this fix the version parsing fails? I'd add that info to the commit message (so that it's clear it's a bug fix when using prerelease sources).

I'd be good to drop the commented out eprintln.

Thanks for your change!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants