chore(rpc): shrink active filters HashMap after clearing stale entries #20660
+6
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
shrink_to_fit()call after removing stale filters inEthFilter::clear_stale_filters().Problem
When filters are removed via
HashMap::retain(), the HashMap keeps its allocated capacity. This means if many filters are created and then expire, the memory stays allocated until the node restarts.Example scenario:
clear_stale_filters()This is known as the "high water mark" problem.
Solution
Call
shrink_to_fit()afterretain()to release unused capacity.This follows the same pattern used in
EthStateCache::shrink_queues()(added in #14105).Before vs After
Testing
cargo check -p reth-rpc --lib✅cargo test -p reth-rpc --lib -- filter✅ (10 tests passed)