Skip to content

refactor: unify witness generation with DebugApi using ExecutionWitnessRecord #20655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
forkfury wants to merge 3 commits into
base: main
Choose a base branch
from
Open

refactor: unify witness generation with DebugApi using ExecutionWitnessRecord #20655

forkfury wants to merge 3 commits into from
+66 −126

Conversation

@forkfury
Copy link
Contributor

@forkfury forkfury commented Dec 28, 2025

Fix

Unifies witness generation with DebugApi::debug_execution_witness by replacing custom implementation with ExecutionWitnessRecord::from_executed_state().

Changes

  • Replace collect_execution_data() and generate() with ExecutionWitnessRecord::from_executed_state()
  • Remove duplicate state_by_block_hash() call in re_execute_block()
  • Add witness feature to reth-revm dependency in Cargo.toml
  • Update tests to use ExecutionWitnessRecord instead of custom functions
  • Remove TODO comment about unification

@github-project-automation github-project-automation bot moved this to Backlog in Reth Tracker Dec 28, 2025
@forkfury forkfury marked this pull request as draft December 28, 2025 14:35
@forkfury forkfury marked this pull request as ready for review December 28, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@mediocregopher mediocregopher Awaiting requested review from mediocregopher mediocregopher is a code owner

@yongkangc yongkangc Awaiting requested review from yongkangc yongkangc is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

Reth Tracker
Status: Backlog

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@forkfury