Skip to content

fix(db-api): set is_done=true in RangeWalker when cursor returns None #20646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dizer-ti wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(db-api): set is_done=true in RangeWalker when cursor returns None #20646

dizer-ti wants to merge 1 commit into from
+1 −1

Conversation

@dizer-ti
Copy link
Contributor

@dizer-ti dizer-ti commented Dec 26, 2025

Set is_done to true in RangeWalker::next() when cursor returns None, regardless of the range bound type. Previously, is_done was only set for Unbounded ranges, leading to unnecessary cursor.next() calls on subsequent
iterations for bounded ranges.

@github-project-automation github-project-automation bot moved this to Backlog in Reth Tracker Dec 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@rakita rakita Awaiting requested review from rakita rakita is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

Reth Tracker
Status: Backlog

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dizer-ti