feat(rpc): handle dedicated eth_simulate errors #20099
Conversation
figtracer
force-pushed
the
handle_dedicated_eth_simulate_rpc_errors
branch
from
b851b3e to
cf00024
Compare
figtracer
force-pushed
the
handle_dedicated_eth_simulate_rpc_errors
branch
from
1f3f9e6 to
8c7312f
Compare
| /// Returns [`EthSimulateError`] if this error maps to a simulate-specific error code. | ||
| fn as_simulate_error(&self) -> Option<EthSimulateError> { |
There was a problem hiding this comment.
okay, this should actually work
| let map_err = |e: EthApiError| -> Self::Error { | ||
| match e.as_simulate_error() { | ||
| Some(sim_err) => Self::Error::from_eth_err(EthApiError::other(sim_err)), | ||
| None => Self::Error::from_eth_err(e), | ||
| } | ||
| }; |
klkvr
left a comment
klkvr
left a comment
There was a problem hiding this comment.
this makes sense, though I think it's likely that there are some error code fixes that not only apply to simulateV1
| Self::NonceTooLow { .. } => -38010, | ||
| Self::NonceTooHigh => -38011, | ||
| Self::BaseFeePerGasTooLow => -38012, | ||
| Self::IntrinsicGasTooLow => -38013, | ||
| Self::InsufficientFunds { .. } => -38014, | ||
| Self::BlockGasLimitExceeded => -38015, | ||
| Self::BlockNumberInvalid => -38020, | ||
| Self::BlockTimestampInvalid => -38021, | ||
| Self::PrecompileSelfReference => -38022, | ||
| Self::PrecompileDuplicateAddress => -38023, | ||
| Self::SenderNotEOA => -38024, | ||
| Self::MaxInitCodeSizeExceeded => -38025, |
There was a problem hiding this comment.
would be also great to check if any of those codes should apply here
reth/crates/rpc/rpc-eth-types/src/error/mod.rs
Lines 695 to 709 in 7e6a59b
There was a problem hiding this comment.
i agree, let me take a look at it
There was a problem hiding this comment.
actually i think we can leave it like this, there's nothing else to be added here
pub const fn error_code(&self) -> i32 {
match self {
Self::InvalidChainId |
Self::GasTooLow |
Self::GasTooHigh |
Self::GasRequiredExceedsAllowance { .. } |
...
}
}the generic json-rpc codes stay at RpcInvalidTransactionError and the conversion for (if needed) is handled by as_simulate_error(). the ones that don't match are specific
3 participants
solves #20054 by:
EthSimulateErrorfollowing execution-apis and geth/ethapi/errorsAsEthApiErrorwith as_simulate_error() to match RpcInvalidTransactionError counterpartssimulate_v1using this new method