Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: call validate_execution_requests from validate_version_specific_fields for ethereum engine validator #14932

Merged
merged 8 commits into from
Mar 11, 2025
Merged

fix: call validate_execution_requests from validate_version_specific_fields for ethereum engine validator #14932

merged 8 commits into from
Mar 11, 2025

Conversation

fgimenez
Copy link
Member

@fgimenez fgimenez commented Mar 10, 2025 •
edited
Loading

Closes #14933

@fgimenez fgimenez added C-hivetest Used for labelling automated issues relating to hive test failures A-ci Related to github workflows or other build and lint tools labels Mar 10, 2025
@fgimenez fgimenez requested review from mattsse and removed request for onbjerg, gakonst and DaniPopes March 10, 2025 15:36
@fgimenez fgimenez enabled auto-merge March 10, 2025 15:36
mattsse
mattsse approved these changes Mar 10, 2025
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can likely fix some of those with additional checks but imo this is unnecessary because any malformed requests will end up as invalid payload anyway

@mattsse mattsse disabled auto-merge March 10, 2025 15:45
@mattsse mattsse mentioned this pull request Mar 10, 2025
Closed
@fgimenez fgimenez requested a review from Rjected as a code owner March 11, 2025 10:27
mattsse
mattsse reviewed Mar 11, 2025
View reviewed changes
crates/payload/primitives/src/payload.rs Outdated
/// Returns `None` in all other cases.
pub fn execution_requests(&self) -> Option<&Requests> {
if let Self::ExecutionPayload(payload) = self {
payload.sidecar.prague().and_then(|prague_fields| match &prague_fields.requests {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's also fn requests -> Option<&Requests> I believe

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome thx! changes to use it here 3cc6d1b

@fgimenez fgimenez changed the title chore(ci): ignore hive tests failing in eest/consume-engine fix: call validate_execution_requests from validate_version_specific_fields for ethereum engine validator Mar 11, 2025
@fgimenez fgimenez added the A-engine Related to the engine implementation label Mar 11, 2025
@fgimenez
Copy link
Member Author

successful hive execution from this branch https://github.com/paradigmxyz/reth/actions/runs/13786338679

mattsse
mattsse requested changes Mar 11, 2025
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

can we remove this function entirely

reth/crates/engine/primitives/src/lib.rs

Lines 139 to 145 in aaae309

/// Validates the execution requests according to [EIP-7685](https://eips.ethereum.org/EIPS/eip-7685).
fn validate_execution_requests(
&self,
requests: &Requests,
) -> Result<(), EngineObjectValidationError> {
validate_execution_requests(requests)
}

@fgimenez fgimenez requested a review from rkrasiuk as a code owner March 11, 2025 11:56
@fgimenez
Copy link
Member Author

can we remove this function entirely

sure, done here 66765ac

@mattsse mattsse enabled auto-merge March 11, 2025 12:00
@mattsse mattsse added this pull request to the merge queue Mar 11, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 11, 2025
@mattsse mattsse merged commit e536fbc into main Mar 11, 2025
42 checks passed
@mattsse mattsse deleted the fgimenez/ignore-hive-eest-tests branch March 11, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

Assignees
No one assigned
Labels
A-ci Related to github workflows or other build and lint tools A-engine Related to the engine implementation C-hivetest Used for labelling automated issues relating to hive test failures
Projects
Reth Tracker
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move validate_requests fn into validate version specific fields for ethereum engine validator
2 participants
@fgimenez @mattsse