Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement compact for alloy ethereum transaction #14908

Merged
merged 5 commits into from
Mar 10, 2025
Merged

feat: implement compact for alloy ethereum transaction #14908

merged 5 commits into from
Mar 10, 2025
+79 −28

Conversation

stevencartavia
Copy link
Contributor

closes #14898

mattsse
mattsse requested changes Mar 8, 2025
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits

Cargo.toml Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to update everything in lockstep so we need to bump every alloy deps to 0.12.3 here, or directly to 0.12.4 now

crates/storage/codecs/src/alloy/transaction/mod.rs Outdated
B: BufMut + AsMut<[u8]>,
{
let identifier = self.tx_type().to_compact(buf);
delegate!(self => tx.to_compact(buf));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we only use this once, so we can remove the macro and delegate in place

@mattsse mattsse marked this pull request as ready for review March 8, 2025 06:25
@mattsse mattsse requested review from joshieDo and gakonst as code owners March 8, 2025 06:25
@mattsse mattsse added the A-db Related to the database label Mar 8, 2025
@mattsse mattsse enabled auto-merge March 10, 2025 14:23
@mattsse mattsse added this pull request to the merge queue Mar 10, 2025
Merged via the queue into paradigmxyz:main with commit 7300872 Mar 10, 2025
42 checks passed
@mattsse mattsse mentioned this pull request Mar 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-db Related to the database
Projects
Reth Tracker
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement compact for alloy ethereum transaction
2 participants
@stevencartavia @mattsse