Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rm unused capabilities code #13935

Merged
merged 3 commits into from
Jan 22, 2025
Merged

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jan 22, 2025

this type is a bit of a footgun and is an old relict when we were looking into other subprotocols.

it's not worth keeping because unuseful.

also removes unreachable event variants that were never instantiated

@mattsse mattsse requested a review from Rjected as a code owner January 22, 2025 20:43
@mattsse mattsse added C-debt Refactor of code section that is hard to understand or maintain A-networking Related to networking in general labels Jan 22, 2025
@mattsse mattsse enabled auto-merge January 22, 2025 20:44
@mattsse mattsse added this pull request to the merge queue Jan 22, 2025
Merged via the queue into main with commit 6937578 Jan 22, 2025
43 checks passed
@mattsse mattsse deleted the matt/rm-unused-capability-types2 branch January 22, 2025 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-networking Related to networking in general C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants