feat(test-utils): Make MockEthProvider generic over Transaction #13853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dhanraj30
requested review from
rakita,
joshieDo and
shekhirin
as code owners
mattsse
requested changes
Jan 18, 2025
| @@ -42,7 +42,7 @@ use std::{ | |||
|
|
|||
| /// A mock implementation for Provider interfaces. | |||
| #[derive(Debug, Clone)] | |||
| pub struct MockEthProvider { | |||
| pub struct MockEthProvider<T = TransactionSigned> { | |||
There was a problem hiding this comment.
this alone doesn't do much yet,
could we maybe relax the impls as well and use this tx type in Blocks?
perhaps a better generic would actually be B: Block
mattsse
requested changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
detail: #13835
This change makes MockEthProvider more flexible and allows it to be used with different types of transactions, such as OpSignedTransaction.