Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: merge BlockBodyTxExt trait into BlockBody #13613

Merged
merged 10 commits into from
Jan 3, 2025
Merged

feat: merge BlockBodyTxExt trait into BlockBody #13613

merged 10 commits into from
Jan 3, 2025
+46 −34

Conversation

hoank101
Copy link
Contributor

@hoank101 hoank101 commented Jan 1, 2025

Closes #13609

@hoank101 hoank101 marked this pull request as ready for review January 1, 2025 09:39
mattsse
mattsse requested changes Jan 3, 2025
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smol feature nit

.github/workflows/unit.yml Outdated Show resolved Hide resolved
@hoank101 hoank101 requested a review from mattsse January 3, 2025 13:26
@hoank101
Copy link
Contributor Author

hoank101 commented Jan 3, 2025

smol feature nit

i just update, please help me review, thank you

@mattsse mattsse added this pull request to the merge queue Jan 3, 2025
@mattsse mattsse added the A-sdk Related to reth's use as a library label Jan 3, 2025
@mattsse mattsse removed this pull request from the merge queue due to a manual request Jan 3, 2025
@mattsse mattsse enabled auto-merge January 3, 2025 15:44
@mattsse mattsse added this pull request to the merge queue Jan 3, 2025
Merged via the queue into paradigmxyz:main with commit 8f854cb Jan 3, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@DaniPopes DaniPopes Awaiting requested review from DaniPopes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

Assignees
No one assigned
Labels
A-sdk Related to reth's use as a library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Merge BlockBodyTxExt trait into BlockBody
2 participants
@hoank101 @mattsse