integrate EIP-7840 in chainspec #13605
Merged
+54
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasmilukas
requested review from
Rjected,
joshieDo and
mattsse
as code owners
|
hey @mattsse, the PR is ready. Lmk if anything needs to be adjusted |
mattsse
requested changes
Jan 4, 2025
| .map(|item| BlobParams { | ||
| target_blob_count: item.target_blob_count, | ||
| max_blob_count: item.max_blob_count, | ||
| ..default() |
There was a problem hiding this comment.
this seems okay, this way we use the correct hardfork settings but use the configured target+max_blob fields
crates/chainspec/src/spec.rs
Outdated
Comment on lines
165
to
166
| pub cancun: BlobParams, | ||
| pub prague: BlobParams, |
mattsse
added
C-enhancement
mattsse
approved these changes
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13600.
Lmk if any adjustments are needed!