feat: optional rayon #13552
Closed
feat: optional rayon #13552
+68
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lightsing
requested review from
rkrasiuk,
Rjected,
shekhirin,
joshieDo,
mattsse,
klkvr and
gakonst
as code owners
lightsing
force-pushed
the
feat/opt-rayon
branch
from
afa7b8f to
1a318a0
Compare
CodSpeed Performance ReportMerging #13552 will degrade performances by 10.66%Comparing Summary
Benchmarks breakdown
|
mattsse
reviewed
Dec 25, 2024
Comment on lines
+96
to
+101
| /// Helper trait that requires rayon since `rayon` feature is enabled. | ||
| #[cfg(feature = "rayon")] | ||
| pub trait MaybeIntoParallelIterator: | ||
| rayon::iter::IntoParallelIterator<Item = <Self as MaybeIntoParallelIterator>::Item> | ||
| + IntoIterator<Item = <Self as MaybeIntoParallelIterator>::Item> | ||
| { |
There was a problem hiding this comment.
not really a fan of this,
I think I'd rather two recovery fns instead
mattsse
reviewed
Jan 3, 2025
There was a problem hiding this comment.
I'd like to close this pr because the correct way to do this described in #13635 and I think it's easier to start over @lightsing wdyt?
|
thx @mattsse |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issue: #13443
todo: when alloy-core is bumped to a release contains alloy-rs/core#827, propagate feature to
alloy-primitives/rayon