feat: use alloy block types #13518
Merged
feat: use alloy block types #13518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested review from
rakita,
joshieDo,
shekhirin,
Rjected,
klkvr,
fgimenez and
onbjerg
as code owners
mattsse
commented
Dec 31, 2024
| @@ -12,3 +13,82 @@ pub trait SerdeBincodeCompat: Sized + 'static { | |||
| impl SerdeBincodeCompat for alloy_consensus::Header { | |||
| type BincodeRepr<'a> = alloy_consensus::serde_bincode_compat::Header<'a>; | |||
| } | |||
|
|
|||
| mod block_bincode { | |||
There was a problem hiding this comment.
this I had to move because the trait is defined here and is generic over SerdeBincodeCompat, we could perhaps move this trait entirely to alloy
mattsse
commented
Dec 31, 2024
| (self.header, self.body) | ||
| } | ||
| } | ||
| pub type Block<T = TransactionSigned> = alloy_consensus::Block<T>; |
There was a problem hiding this comment.
kept these as aliases so we don't break anything
rkrasiuk
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the reth block+blockbody types with alloy's
This allows further simplifications because now we have access to these in reth-primitives-traits.
a few things could use some work:
SealedBlockas the target