Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(sdk): fix docs to match generic tx type #13316

Merged
merged 1 commit into from
Dec 11, 2024
Merged

chore(sdk): fix docs to match generic tx type #13316

merged 1 commit into from
Dec 11, 2024
+3 −3

Conversation

emhane
Copy link
Member

@emhane emhane commented Dec 11, 2024 •
edited
Loading

Ref #12454

Fixes docs to match generic signed transaction type

@emhane emhane added C-docs An addition or correction to our documentation C-debt Refactor of code section that is hard to understand or maintain A-sdk Related to reth's use as a library labels Dec 11, 2024
@emhane emhane enabled auto-merge December 11, 2024 20:28
Rjected
Rjected approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@emhane emhane added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit 3d12a4e Dec 11, 2024
43 checks passed
@emhane emhane deleted the emhane/fix-docs branch December 11, 2024 21:00
emhane added a commit to ethereum-optimism/op-reth that referenced this pull request Dec 13, 2024
@emhane
chore(sdk): fix docs to match generic tx type (paradigmxyz#13316)
93866a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Rjected approved these changes

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

Assignees
No one assigned
Labels
A-sdk Related to reth's use as a library C-debt Refactor of code section that is hard to understand or maintain C-docs An addition or correction to our documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emhane @Rjected