-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce HashedPostStateProvider
#12607
Introduce HashedPostStateProvider
#12607
Conversation
6eeb691
to
3a9fa49
Compare
False negative on failing tests due to #12893 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not a fan of having to initialize hashed post state via provider, but otherwise lgtm
06ef897
to
06f01c4
Compare
I accidentally merged some unrelated work but reset and removed those commits back to the previous reviewed state. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, although wondering if we could move the HashedPostState
construction to StateRootProvider
implementation? it looks like from_bundle_state
is called pretty much always before invoking it.
That way we'll unify code paths and make sure that hashing is only done by the type that knows the configured state commitment impl
pending ci and conflicts |
I would be in support of this idea. However, I need to do some analysis to ensure this is practical for all code paths and evaulate what changes would need to be made. I would suggest we proceed with the current direction and add this as an issue to review and refactor once we have the current implementation stabilized. What do you think? |
Replacement for #11872