Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce HashedPostStateProvider #12607

Merged
merged 14 commits into from
Dec 3, 2024

Conversation

frisitano
Copy link
Contributor

Replacement for #11872

@frisitano frisitano force-pushed the feat/hashed-post-state-provider branch from 6eeb691 to 3a9fa49 Compare November 25, 2024 05:16
@frisitano
Copy link
Contributor Author

False negative on failing tests due to #12893

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all of these make sense to me

pending @klkvr and @rkrasiuk

Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a fan of having to initialize hashed post state via provider, but otherwise lgtm

@frisitano frisitano requested a review from klkvr as a code owner December 2, 2024 02:22
@frisitano frisitano force-pushed the feat/hashed-post-state-provider branch from 06ef897 to 06f01c4 Compare December 2, 2024 03:42
@frisitano
Copy link
Contributor Author

I accidentally merged some unrelated work but reset and removed those commits back to the previous reviewed state.

Copy link
Collaborator

@klkvr klkvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, although wondering if we could move the HashedPostState construction to StateRootProvider implementation? it looks like from_bundle_state is called pretty much always before invoking it.

That way we'll unify code paths and make sure that hashing is only done by the type that knows the configured state commitment impl

@klkvr
Copy link
Collaborator

klkvr commented Dec 2, 2024

pending ci and conflicts

@frisitano
Copy link
Contributor Author

lgtm, although wondering if we could move the HashedPostState construction to StateRootProvider implementation? it looks like from_bundle_state is called pretty much always before invoking it.

That way we'll unify code paths and make sure that hashing is only done by the type that knows the configured state commitment impl

I would be in support of this idea. However, I need to do some analysis to ensure this is practical for all code paths and evaulate what changes would need to be made. I would suggest we proceed with the current direction and add this as an issue to review and refactor once we have the current implementation stabilized. What do you think?

@klkvr klkvr added this pull request to the merge queue Dec 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 3, 2024
@mattsse mattsse enabled auto-merge December 3, 2024 16:43
@mattsse mattsse added this pull request to the merge queue Dec 3, 2024
Merged via the queue into paradigmxyz:main with commit 886471d Dec 3, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants