perf: introduce moka cached state provider #12214
Merged
+444
−130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rjected
added
C-enhancement
Rjected
requested review from
rkrasiuk,
mattsse,
fgimenez and
gakonst
as code owners
Rjected
force-pushed
the
dan/add-cached-state-provider
branch
from
d66da1a to
29b53b1
Compare
perf: add builders
Rjected
force-pushed
the
dan/add-cached-state-provider
branch
from
29b53b1 to
e4d6be1
Compare
DaniPopes
approved these changes
Jan 8, 2025
Rjected
force-pushed
the
dan/add-cached-state-provider
branch
from
8da1c4f to
3f81fd1
Compare
gakonst
reviewed
Jan 8, 2025
| self.state_provider.proof(input, address, slots) | ||
| } | ||
|
|
||
| fn multiproof( |
There was a problem hiding this comment.
What's the plan for this? Also these caches should probably work across blocks too?
There was a problem hiding this comment.
rather than caching proofs right now, we'll send messages to the state root task, which will use a different provider to fetch + cache proofs itself for each block
We should start with intra-block caching, but for cross-block caching, we would need to apply state updates to the cache, instead of invalidating each block. Maybe we could also incorporate trie updates as well
DaniPopes
reviewed
Jan 8, 2025
Cargo.lock
Outdated
| dependencies = [ | ||
| "base64 0.22.1", | ||
| "indexmap 2.7.0", | ||
| "metrics", | ||
| "metrics-util", | ||
| "metrics-util 0.19.0", |
There was a problem hiding this comment.
I think this is a problem because it duplicates metrics, please revert or bump metrics-util locally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a currently unused cached state provider, which uses
mokacaches, so the caches can be shared among multipleCachedStateProvidersref #12052, #13713