Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate EIP-7840 in chainspec #13600

Open
mattsse opened this issue Dec 30, 2024 · 3 comments · May be fixed by #13605
Open

Integrate EIP-7840 in chainspec #13600

mattsse opened this issue Dec 30, 2024 · 3 comments · May be fixed by #13605
Assignees
@tomasmilukas
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Dec 30, 2024

Describe the feature

with EIP-7840 we have configurable blobparams

https://github.com/alloy-rs/alloy/blob/28e9c846112635478009049d23a83ce077d24559/crates/genesis/src/lib.rs#L484-L488

this affects:

  • cancun
  • prague

we need to integrate these into ChainSpec, similar to

reth/crates/chainspec/src/spec.rs

Lines 202 to 203 in 0b135a2

/// The parameters that configure how a block's base fee is computed
pub base_fee_params: BaseFeeParamsKind,

but BlobParams based for hardforks.

TODO

  • we need a new container type that has cancun: BlobParams, prague: BlobParams as fields
  • add as field to ChainSpec
  • add appropriate conversion here:

    reth/crates/chainspec/src/spec.rs

    Lines 589 to 590 in 0b135a2

    impl From<Genesis> for ChainSpec {
    fn from(genesis: Genesis) -> Self {

Additional context

https://github.com/ethereum/EIPs/pull/9129/files
@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Dec 30, 2024
@mattsse mattsse added D-good-first-issue Nice and easy! A great choice to get started and removed S-needs-triage This issue needs to be labelled labels Dec 30, 2024
@tomasmilukas
Copy link
Contributor

tomasmilukas commented Dec 30, 2024 •
edited
Loading

can i take this?

@mattsse
Copy link
Collaborator Author

mattsse commented Dec 30, 2024

assigned, ty!
lmk if you need pointers

@tomasmilukas tomasmilukas linked a pull request Dec 31, 2024 that will close this issue
Open
@mymiracle0118
Copy link

I’d like to resolve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomasmilukas tomasmilukas

Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

integrate EIP-7840 in chainspec tomasmilukas/reth
3 participants
@mattsse @tomasmilukas @mymiracle0118