Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gate rayon usage behind a feature #13443

Open
lightsing opened this issue Dec 19, 2024 · 1 comment
Open

Gate rayon usage behind a feature #13443

lightsing opened this issue Dec 19, 2024 · 1 comment
Labels
C-enhancement New feature or request S-needs-triage This issue needs to be labelled

Comments

@lightsing
Copy link
Contributor

Describe the feature

There's serval reasons to do this:

  • when using alloy-primitives::map::HashMap (eg. std not enabled), the rayon::IntoParallelIterator is not enabled for alloy-primitives::map::HashMap by default, also alloy-primitives did not re-export the hashbrown/rayon feature, user have to enable it via hashbrown crate.
  • for zk related usage, parallel is usually not a thing, rayon introduce extra cost here.

Additional context

No response
@lightsing lightsing added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Dec 19, 2024
@lightsing
Copy link
Contributor Author

related alloy-rs/core#827

@lightsing lightsing mentioned this issue Dec 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement New feature or request S-needs-triage This issue needs to be labelled
Projects
Reth Tracker
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lightsing