Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: accessibility improvements for tags, doc links, dashboard views #6786

Merged
merged 5 commits into from
May 22, 2024

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented May 20, 2024

Proposed change

I do like to support accessibility, this is some 'low-hanging fruit'. There are no visual (see unexciting screenshots because they look exactly the same as current) or functionality changes here.

  • Use interactive elements (<button>) for remove 'x' for tags button & doc links
  • Adds titles to the buttons in dropdowns (again, used by screen readers)
  • Make tags on dashboard an interactive element (<a>)
  • Add titles to interactive elements on the dashboard
Screenshot 2024-05-20 at 9 56 18 AM Screenshot 2024-05-20 at 10 00 01 AM Screenshot 2024-05-20 at 10 08 21 AM

Closes #6784

Type of change

  • Bug fix: non-breaking change which fixes an issue.
  • New feature / Enhancement: non-breaking change which adds functionality. Please read the important note above.
  • Breaking change: fix or feature that would cause existing functionality to not work as expected.
  • Documentation only.
  • Other. Please explain:

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have included testing coverage for new code in this PR, for backend and / or front-end changes.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon shamoon requested a review from a team as a code owner May 20, 2024 17:13
@paperless-ngx-secretary paperless-ngx-secretary bot added frontend non-trivial Requires approval by several team members labels May 20, 2024
@shamoon shamoon enabled auto-merge (squash) May 20, 2024 17:14
Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.19%. Comparing base (2116964) to head (4545969).
Report is 1 commits behind head on dev.

Current head 4545969 differs from pull request most recent head 55457ef

Please upload reports for the commit 55457ef to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #6786   +/-   ##
=======================================
  Coverage   97.19%   97.19%           
=======================================
  Files         436      436           
  Lines       17981    17981           
  Branches     1440     1520   +80     
=======================================
  Hits        17477    17477           
+ Misses        504      501    -3     
- Partials        0        3    +3     
Flag Coverage Δ
backend 95.88% <ø> (ø)
frontend 98.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shamoon shamoon added this to the Next Release milestone May 20, 2024
@shamoon shamoon merged commit c0c44b5 into dev May 22, 2024
25 checks passed
@shamoon shamoon deleted the 6784-tag-button branch May 22, 2024 23:08
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns. See our contributing guidelines for more details.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frontend non-trivial Requires approval by several team members
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants