feature/DS-1182: Update PDS-Toolkit package to version 1.0.0 dev.217

[gfbollingerHakuna]

Summary

The @pantheon-systems/pds-toolkit-react package was updated to version: 1.0.0 dev.217.

Details

I reviewed each release, examining the breaking changes for every affected component to understand the changes and make the necessary adjustments.

[rachelwhitton]

@gfbollingerHakuna I'm seeing an error causing build failures on this branch:

Error message:
ReferenceError: window is not defined

File:
node_modules/@pantheon-systems/pds-toolkit-react/_dist/index.js:1591:1

Stack:
WebpackError: ReferenceError: window is not defined
    at pantheon-documentation/node_modules/@pantheon-systems/pds-toolkit-react/_dist/index.js:1591:1
    at pantheon-documentation/node_modules/@pantheon-systems/pds-toolkit-react/_dist/index.js:1606:1
    at pantheon-documentation/node_modules/@pantheon-systems/pds-toolkit-react/node_modules/@floating-ui/react/dist/floating-ui.react.esm.js:1981:1
    at pantheon-documentation/node_modules/@pantheon-systems/pds-toolkit-react/node_modules/@floating-ui/react/dist/floating-ui.react.esm.js:1898:1
    at pantheon-documentation/node_modules/@pantheon-systems/pds-toolkit-react/node_modules/@floating-ui/react/dist/floating-ui.react.esm.js:2381:1
    at pantheon-documentation/node_modules/@pantheon-systems/pds-toolkit-react/node_modules/@floating-ui/react/dist/floating-ui.react.esm.js:2318:1
    at pantheon-documentation/node_modules/@pantheon-systems/pds-toolkit-react/node_modules/@floating-ui/react/dist/floating-ui.react.esm.js:2926:1
    at pantheon-documentation/.cache/ssr-develop-static-entry.js:304:35
    at pantheon-documentation/node_modules/@gatsbyjs/reach-router/es/lib/history.js:61:1
    at pantheon-documentation/.cache/ssr-develop-static-entry.js:334:19

[rachelwhitton]

@mel-miller @gfbollingerHakuna while we're looking at design updates, could this PR include styling fixes for spacing inconsistencies for lists?

Here's what I'd like to address:

1. (this is my main ask) Increase bottom margin for <ul> classes (currently bottom margin is 0) - end of the list is too close to the next thing on the page, which is often an unrelated <p> or a new header introducing a new topic or subject

2. (nice to have) Consider reducing the top margin while we're at it (currently top margin is 16) - usually we have a <p> introduce a <ul> and I prefer no extra space between the two but I could be convinced otherwise

3. (nice to have) Recommend a standard for line break usage. For example, the inconsistencies shown below are largely a result of using line breaks in some lists and not using them in others. I prefer no line breaks personally, but would like to know your thoughts on what standard should be applied

example doc:

[pantheon-decoupled]

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-9394-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

[pantheon-decoupled]

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-9394-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

build error has been fixed

[pantheon-decoupled]

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-9394-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

[gfbollingerHakuna]

Hi @rachelwhitton!
After fixing the hook in the DS that was causing the build issue, I made a couple of style adjustments for points 1 and 2 as you requested. Let me know what you think.

For point 3, perhaps having no breaks is better. The existing ones can be removed if needed.

Let me know if my changes are OK and if any more are needed. Thanks!

[rachelwhitton]

@gfbollingerHakuna thanks for your work! I'm still seeing the same margins on <ul> where top margin is 16 and bottom margin is 0

here's what i'm still seeing:

here's what i'd like to see instead:

[pantheon-decoupled]

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-9394-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

[gfbollingerHakuna]

Hi @rachelwhitton, sorry, it seems I overlooked regular lists and only focused on the nested ones.
I’ve made the adjustments; let me know what you think!
Just so you know, when I tested it in the preview link, it seems the styles were cached, but when I opened it in an incognito window or with a random query string like: https://pr-9394-documentation.appa.pantheon.site/pantheon-workflow?id=2, I was able to see the changes.
Let me know if anything else is needed. Or if this needs further adjusting
Thanks!

[rachelwhitton]

Thanks @gfbollingerHakuna this is an improvement! I think I'd still prefer if the top margin was removed completely (leaving the bottom margin at 16)

[gfbollingerHakuna]

Hi @rachelwhitton! I made further adjustments. Let me know what you think. Thanks!

[pantheon-decoupled]

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-9394-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview