Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove gatsby-remark-embed-markdown to resolve dependabot alert #14 #9036

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Remove gatsby-remark-embed-markdown to resolve dependabot alert #14 #9036

merged 1 commit into from
Jun 11, 2024

Conversation

rachelwhitton
Copy link
Member

@rachelwhitton rachelwhitton commented Jun 10, 2024 •
edited
Loading

Resolves critical dependabot alert https://github.com/pantheon-systems/documentation/security/dependabot/14

Removes gatsby-remark-embed-markdown

VRT ran locally with 8 scenarios passed

@rachelwhitton rachelwhitton requested a review from a team as a code owner June 10, 2024 18:57
@pantheon-decoupled Pantheon Decoupled
Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-9036-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

@rachelwhitton rachelwhitton self-assigned this Jun 10, 2024
@rachelwhitton
Copy link
Member Author

@mel-miller can you review?

@rachelwhitton rachelwhitton added Site: Site Structure Issue or PR with the docs app stack and/or live site dependencies Pull requests that update a dependency file Process: High Priority Issue is critical / needs immediate attention labels Jun 10, 2024
mel-miller
mel-miller approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@mel-miller mel-miller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good. I don't see it being used anywhere.

stevector
stevector approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@stevector stevector left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the VRT from #9007 and saw no problem (other than a small false positive).

@stevector stevector merged commit d758c41 into main Jun 11, 2024
9 checks passed
@stevector stevector deleted the gatsby-remark-embed-markdown branch June 11, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mel-miller mel-miller mel-miller approved these changes

@stevector stevector stevector approved these changes

Assignees

@rachelwhitton rachelwhitton

Labels
dependencies Pull requests that update a dependency file Process: High Priority Issue is critical / needs immediate attention Site: Site Structure Issue or PR with the docs app stack and/or live site
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rachelwhitton @stevector @mel-miller