Add initial qos story for system and containers #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asac
force-pushed
the
feature/initial-oom-score-adj
branch
from
f92e43a
to
1099d5e
Compare
|
pushed new revision that supports qos_policy: "guaranteed, besteffort and burstable"; also sets system pids to guaranateed. |
asac
changed the title
|
TODO:
|
asac
force-pushed
the
feature/initial-oom-score-adj
branch
4 times, most recently
from
3739f4f
to
abaeda6
Compare
|
i fixed all TODOS except the burstable impl is still dumb... would like to land as is... |
|
think memleak still with |
* containers get qos_policy config in run.json * values from k8s: -997 guaranteed, 1000 besteffort, 333 burstable * make values configurable in pantavisor.config; overloadable in initrd_config * vm.oom_qos_besteffort * vm.oom_qos_guaranteed * system gets guaranteed -997 as well, loggers get -333
asac
force-pushed
the
feature/initial-oom-score-adj
branch
from
abaeda6
to
913441a
Compare
| @@ -186,6 +186,11 @@ struct pantavisor_metadata { | |||
| int usrmeta_interval; | |||
| }; | |||
|
|
|||
| struct pantavisor_vm { | |||
| int oom_qos_besteffort; | |||
There was a problem hiding this comment.
whould be nice to have these in pv_config_get_json and pv_config_print too
There was a problem hiding this comment.
sure lets add there....
| @@ -445,6 +445,11 @@ static int pv_config_load_file(char *path, struct pantavisor_config *config) | |||
| config_iterate_items_prefix(&config_list, config_sysctl_apply, | |||
| "sysctl.", NULL); | |||
|
|
|||
| config->vm.oom_qos_besteffort = config_get_value_int( | |||
| &config_list, "vm.oom_qos_besteffort", 1000); | |||
There was a problem hiding this comment.
I don't like the names very much, but I cannot think of something better either :)
There was a problem hiding this comment.
we can add a . in the middle, but then i dont know the benefit :)
|
needs docs/ update for new config keys. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add initial oom score adjustments to ensure that on pantavisor system pantavisor itself and the log facilities get killed last by oom handler