Add CI/benchmarks for Ruby 3.3 #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #335 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 190 190
Branches 90 90
=========================================
Hits 190 190 ☔ View full report in Codecov by Sentry. |
JacobEvelyn
force-pushed
the
ruby-3-3
branch
2 times, most recently
from
21f5728
to
29d08dd
Compare
JacobEvelyn
force-pushed
the
ruby-3-3
branch
3 times, most recently
from
1c0359b
to
b274e8e
Compare
JacobEvelyn
commented
Jun 10, 2024
| |`(a, *args)`|0.78x|1.60x| | ||
| |`(a:, **kwargs)`|0.77x|2.12x| | ||
| |`(a, *args, b:, **kwargs)`|0.69x|1.40x| | ||
| |`()` (none)|0.60x|3.17x| |
There was a problem hiding this comment.
I'm pretty surprised by the performance degradation here—worse results basically across the board. I don't have time to investigate though. @ms-ati do you?
This commit updates our CI to run tests and benchmarks on Ruby 3.3. Note that it does not yet run CI benchmarks using YJIT. As a part of this change, the `dokaz` gem is pinned to run on Ruby 3.2 instead of the latest Ruby version because the gem does not work in 3.3+. If that changes, we can go back to running it on the latest supported Ruby. See: zverok/dokaz#3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates our CI to run tests and
benchmarks on Ruby 3.3. Note that it does not
yet run CI benchmarks using YJIT.
As a part of this change, the
dokazgemis pinned to run on Ruby 3.2 instead of the
latest Ruby version because the gem does
not work in 3.3+. If that changes, we can
go back to running it on the latest supported
Ruby. See: zverok/dokaz#3
Before merging:
README.mdand update this PRCHANGELOG.md, add an entry following Keep a Changelog guidelines with semantic versioning