Skip to content

Fix failing golangci-lint in CI #1330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 2, 2025
Merged

Fix failing golangci-lint in CI #1330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
354190b
Ensure golangci-lint will pass if downgrade the action to 6.4.1
kachick Apr 2, 2025
f89968e
Bump golangci-lint-action to 6.5.0 for making sure the updating made …
kachick Apr 2, 2025
30a9323
Update deprecated option skip-dirs with issues.exclude-dirs
kachick Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/hashira-cui--test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,6 @@ jobs:
with:
go-version-file: "go.mod"
cache-dependency-path: "go.sum"
- uses: golangci/golangci-lint-action@v6
- uses: golangci/golangci-lint-action@2226d7cb06a077cd73e56eedd38eecad18e5d837 # v6.5.0
Copy link
Collaborator Author

@kachick kachick Apr 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

敢えてこのトラブルが発生しだした一番古いversionに止めてある
これ以降の更新は dependabot が出してくるはずなのでそれ単位で

with:
version: v1.63.4
7 changes: 4 additions & 3 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
skip-dirs:
- service
- hashira-web/
issues:
exclude-dirs:
Comment on lines +1 to +2
Copy link
Collaborator Author

@kachick kachick Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

この config 自体は golangci-lint config verify で verify をかけられるんだけれど、migrationガイドに沿って一足飛びに v2 系の linters.exclusions に差し替えようとするとやはり落ちる。
schema に version が用意されたのも最近の様で、指定ができない
migration tool も v1 時代から deprecate だった config には対応していないらしい
ということで、一旦古い情報を探すと golangci/golangci-lint#4509 での更新内容に添わせれば一旦通るようだった。
v2 系に上げるときには再度見直しが必要っぽいけどとりあえずこれで

- service
- hashira-web/