Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyQG Ross2022 #239

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

PyQG Ross2022 #239

wants to merge 13 commits into from

Conversation

cmdupuis3
Copy link

Re: #231

@cmdupuis3 cmdupuis3 changed the title PyQG ross2022 PyQG Ross2022 Dec 20, 2022
@cisaacstern
Copy link
Member

pre-commit.ci autofix

@cisaacstern
Copy link
Member

@cmdupuis3 the CI failure is because your PR adds a subdirectory to the top-level of this repo.

As noted here, the contributed directory should be a subdirectory of the recipes directory:

staged-recipes/recipes/
                └──{dataset-name}/
                        ├──meta.yaml
                        └──{recipe-module-name}.py

Could you push a commit moving PyQG_subgrid_forcing_Ross2022 into recipes/?

@cmdupuis3
Copy link
Author

pre-commit.ci autofix

Copy link
Member

@cisaacstern cisaacstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cmdupuis3, two edits here:

  1. You're defining a dict of recipes, rather than a single recipe object, so we'll just the dict_object syntax in meta.yaml. Apologies that this is very poorly documented and I'm not sure there is an official source to point to for it at the moment. So no way you could've known!
  2. We don't need the list of compiled recipes at the end of the recipe module, so I've suggested to remove that. The backend service will do this compilation automatically (and in a different way) from the dict of recipes.

recipes/PyQG_subgrid_forcing_Ross2022/meta.yaml Outdated Show resolved Hide resolved
recipes/PyQG_subgrid_forcing_Ross2022/recipe.py Outdated Show resolved Hide resolved
@cmdupuis3
Copy link
Author

pre-commit.ci autofix

@cisaacstern
Copy link
Member

/run eddy/low_res.zarr

@pangeo-forge
Copy link
Contributor

pangeo-forge bot commented Jan 10, 2023

The test failed, but I'm sure we can find out why!

Pangeo Forge maintainers are working diligently to provide public logs for contributors.
That feature is not quite ready yet, however, so please reach out on this thread to a
maintainer, and they'll help you diagnose the problem.

@cisaacstern
Copy link
Member

/run eddy/low_res.zarr

@pangeo-forge
Copy link
Contributor

pangeo-forge bot commented Jan 10, 2023

The test failed, but I'm sure we can find out why!

Pangeo Forge maintainers are working diligently to provide public logs for contributors.
That feature is not quite ready yet, however, so please reach out on this thread to a
maintainer, and they'll help you diagnose the problem.

@rabernat
Copy link
Contributor

This is now blocked on the issue reported in m2lines/pyqg_parameterization_benchmarks#6

@cmdupuis3
Copy link
Author

/run eddy/low_res.zarr

@cmdupuis3
Copy link
Author

cmdupuis3 commented Feb 17, 2023

Hey @cisaacstern, the issue blocking this was resolved a couple of weeks ago, with no changes needed on our end, as I understand it. Do you think we can get this moving again?

On the other hand, my testbed notebook is now throwing this error 😬

ValueError: Starting with Zarr 2.11.0, stores must be subclasses of BaseStore, if your store exposes the MutableMapping interface wrap it in Zarr.storage.KVStore. Got <File-like object HTTPFileSystem, https://g-402b74.00888.8540.data.globus.org/eddy/high_res.zarr>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants