-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PyQG Ross2022 #239
base: master
Are you sure you want to change the base?
PyQG Ross2022 #239
Conversation
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
@cmdupuis3 the CI failure is because your PR adds a subdirectory to the top-level of this repo. As noted here, the contributed directory should be a subdirectory of the
Could you push a commit moving |
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cmdupuis3, two edits here:
- You're defining a dict of recipes, rather than a single recipe object, so we'll just the
dict_object
syntax in meta.yaml. Apologies that this is very poorly documented and I'm not sure there is an official source to point to for it at the moment. So no way you could've known! - We don't need the list of compiled recipes at the end of the recipe module, so I've suggested to remove that. The backend service will do this compilation automatically (and in a different way) from the dict of recipes.
Co-authored-by: Charles Stern <[email protected]>
Co-authored-by: Charles Stern <[email protected]>
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
/run eddy/low_res.zarr |
The test failed, but I'm sure we can find out why! Pangeo Forge maintainers are working diligently to provide public logs for contributors. |
/run eddy/low_res.zarr |
The test failed, but I'm sure we can find out why! Pangeo Forge maintainers are working diligently to provide public logs for contributors. |
This is now blocked on the issue reported in m2lines/pyqg_parameterization_benchmarks#6 |
/run eddy/low_res.zarr |
Hey @cisaacstern, the issue blocking this was resolved a couple of weeks ago, with no changes needed on our end, as I understand it. Do you think we can get this moving again? On the other hand, my testbed notebook is now throwing this error 😬
|
Re: #231