Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label assignments for 'Inconclusive' and counterscreen actives #51

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

skearnes
Copy link
Contributor

@skearnes skearnes commented Dec 2, 2014

  • Compounds marked 'Inconclusive' in PCBA assays are assigned label -1.
  • New Counterscreen class to handle counterscreens: compounds active in both primary assays and at least one counterscreen are assigned label -2.
  • parse_pcba_targets.py now takes a --counterscreen argument.

@rbharath
Copy link
Contributor

rbharath commented Dec 2, 2014

LGTM for the content of the code.

But, considering our time constraints, I'm going to advocate that we punt on training models with inconclusive compounds and counterscreens for now. There's already a large number of TODOs for the paper, and this one is relatively low priority.

I think that the issue of inconclusive compounds should be properly handled (with empirical measurements of the effects of inconclusive vs. inactive and screen vs. counterscreen) in our MoleculeNet paper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants