Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning for sharex/sharey when subplots=False in plot method #60323

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add warning for sharex/sharey when subplots=False in plot method #60323

wants to merge 1 commit into from
+20 −0

Conversation

MehdiNemri
Copy link

mroeschke
mroeschke requested changes Nov 15, 2024
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, but the issue hasn't had much discussion on a resolution so I think it may be too early to open a PR for this.

That being said, this is probably more appropriate as a documentation inclusion instead of a warning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ignore sharex unless subplots=True
2 participants
@MehdiNemri @mroeschke