Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added navigation in programming #71

Open
wants to merge 6 commits into
base: 1.10
Choose a base branch
from
Open

Conversation

ash1215
Copy link

@ash1215 ash1215 commented Jul 18, 2020

No description provided.

@ash1215 ash1215 marked this pull request as draft July 18, 2020 23:06
Copy link
Member

@rdb rdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There appears to be an extra unnecessary navigation subfolder, the structure is now like programming/navigation/navigation/index.rst, was this intended? I don't think we need to reflect the structure of the libraries here, unless you think we are really going to have a lot of pages. Most importantly, I imagine that to start out we will want a page on building navmeshes and one on using navmeshes and querying them, and further pages explaining more advanced usage.

Please note that the purpose of the manual is to explain concepts and usage patterns, primarily. It is not meant to contain lists of methods. That's what the API documentation is for (which can be linked from here, using :class: directives).

Page names should be lowercase, so bam-serialization.rst

Please follow the style guidelines described in the README.md.

@rdb rdb added the gsoc label Jul 20, 2020

.. code-block:: cpp

LPoint3 pos = new LPoint3(0, 1, 5);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incorrect, and should be: LPoint3 pos(0, 1, 5);

pathLine.draw_to(path[i]);
}

GeomNode *lineNode = pathLine.create();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use PT(LineSegs) because the result of new is a pointer

Use PT(GeomNode) to avoid a crash here

Use under_score naming of variables in C++ code

Preferred form of for loop:

for (size_t i = 0; i < path.size(); ++i) {


.. code-block:: cpp

NavMeshBuilder builder = new NavMeshBuilder();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NavMeshBuilder builder;


builder.set_actor_climb(1.5);

You can also get the parameters value as:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"the parameter's value"

Also, prefer property interface over getters/setters, if we have a property interface

plnp.set_pos(10, 20, 0);
render.set_light(plnp);

DirectionalLight dlight = new DirectionalLight('dlight');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PT(PointLight)
PT(DirectionalLight)

@ash1215 ash1215 marked this pull request as ready for review August 25, 2020 03:33
@rdb
Copy link
Member

rdb commented Sep 10, 2020

Thanks for your great work on this! I'm going to hold off on merging this for now until (1) the navmesh implementation is merged into the master branch and (2) we've created a new branch on the documentation repo for the 1.11 docs.

@rdb rdb mentioned this pull request Nov 29, 2021
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants