Update palantir/go-githubapp to v0.5.0 (#201)

Enable the new error metrics and upgrade google/go-github to v32 for compatibility.
palantir · Aug 25, 2020 · a495289 · a495289
1 parent aa9136a
commit a495289
Show file tree

Hide file tree

Showing 129 changed files with 2,313 additions and 685 deletions.
diff --git a/bulldozer/config_fetcher.go b/bulldozer/config_fetcher.go
@@ -19,7 +19,7 @@ import (
 	"fmt"
 	"net/http"
 
-	"github.com/google/go-github/v31/github"
+	"github.com/google/go-github/v32/github"
 	"github.com/pkg/errors"
 	"github.com/rs/zerolog"
 	"gopkg.in/yaml.v2"

diff --git a/bulldozer/merge.go b/bulldozer/merge.go
@@ -22,7 +22,7 @@ import (
 	"strings"
 	"time"
 
-	"github.com/google/go-github/v31/github"
+	"github.com/google/go-github/v32/github"
 	"github.com/pkg/errors"
 	"github.com/rs/zerolog"
 

diff --git a/bulldozer/update.go b/bulldozer/update.go
@@ -17,7 +17,7 @@ package bulldozer
 import (
 	"context"
 
-	"github.com/google/go-github/v31/github"
+	"github.com/google/go-github/v32/github"
 	"github.com/pkg/errors"
 	"github.com/rs/zerolog"
 

diff --git a/go.mod b/go.mod
@@ -5,11 +5,11 @@ go 1.13
 require (
 	github.com/c2h5oh/datasize v0.0.0-20171227191756-4eba002a5eae
 	github.com/die-net/lrucache v0.0.0-20181227122439-19a39ef22a11
-	github.com/google/go-github/v31 v31.0.0
+	github.com/google/go-github/v32 v32.1.0
 	github.com/gregjones/httpcache v0.0.0-20190611155906-901d90724c79
 	github.com/inconshreveable/mousetrap v1.0.0 // indirect
 	github.com/palantir/go-baseapp v0.2.0
-	github.com/palantir/go-githubapp v0.2.1-0.20200423005854-8924ef0f1e86
+	github.com/palantir/go-githubapp v0.5.0
 	github.com/pkg/errors v0.9.1
 	github.com/rs/zerolog v1.18.0
 	github.com/spf13/cobra v0.0.3

diff --git a/go.sum b/go.sum
@@ -28,8 +28,10 @@ github.com/google/go-cmp v0.3.1/go.mod h1:8QqcDgzrUqlUb/G2PQTWiueGozuR1884gddMyw
 github.com/google/go-github/v29 v29.0.2/go.mod h1:CHKiKKPHJ0REzfwc14QMklvtHwCveD0PxlMjLlzAM5E=
 github.com/google/go-github/v29 v29.0.3 h1:IktKCTwU//aFHnpA+2SLIi7Oo9uhAzgsdZNbcAqhgdc=
 github.com/google/go-github/v29 v29.0.3/go.mod h1:CHKiKKPHJ0REzfwc14QMklvtHwCveD0PxlMjLlzAM5E=
-github.com/google/go-github/v31 v31.0.0 h1:JJUxlP9lFK+ziXKimTCprajMApV1ecWD4NB6CCb0plo=
-github.com/google/go-github/v31 v31.0.0/go.mod h1:NQPZol8/1sMoWYGN2yaALIBytu17gAWfhbweiEed3pM=
+github.com/google/go-github/v32 v32.0.0 h1:q74KVb22spUq0U5HqZ9VCYqQz8YRuOtL/39ZnfwO+NM=
+github.com/google/go-github/v32 v32.0.0/go.mod h1:rIEpZD9CTDQwDK9GDrtMTycQNA4JU3qBsCizh3q2WCI=
+github.com/google/go-github/v32 v32.1.0 h1:GWkQOdXqviCPx7Q7Fj+KyPoGm4SwHRh8rheoPhd27II=
+github.com/google/go-github/v32 v32.1.0/go.mod h1:rIEpZD9CTDQwDK9GDrtMTycQNA4JU3qBsCizh3q2WCI=
 github.com/google/go-querystring v1.0.0 h1:Xkwi/a1rcvNg1PPYe5vI8GbeBY/jrVuDX5ASuANWTrk=
 github.com/google/go-querystring v1.0.0/go.mod h1:odCYkC5MyYFN7vkCjXpyrEuKhc/BUO6wN/zVPAxq5ck=
 github.com/gregjones/httpcache v0.0.0-20190611155906-901d90724c79 h1:+ngKgrYPPJrOjhax5N+uePQ0Fh1Z7PheYoUI/0nzkPA=
@@ -46,8 +48,8 @@ github.com/kr/text v0.1.0 h1:45sCR5RtlFHMR4UwH9sdQ5TC8v0qDQCHnXt+kaKSTVE=
 github.com/kr/text v0.1.0/go.mod h1:4Jbv+DJW3UT/LiOwJeYQe1efqtUx/iVham/4vfdArNI=
 github.com/palantir/go-baseapp v0.2.0 h1:EruWj7lBB7koSLuUjWRvNoIXdmowmLGj+rqiuoTnjgs=
 github.com/palantir/go-baseapp v0.2.0/go.mod h1:7rEjgYzWbHLLuY+mV2iJthxTddEc6aO+kFYsjDKNmEs=
-github.com/palantir/go-githubapp v0.2.1-0.20200423005854-8924ef0f1e86 h1:KEuyVd8h0wxk5JX5cLYyvPzMBsUgv3ELHrWCZNWRmBA=
-github.com/palantir/go-githubapp v0.2.1-0.20200423005854-8924ef0f1e86/go.mod h1:FnefEL0l2Z3EIoKYhhtZEeHR8SJgbBNsYtk+Nh7Muf4=
+github.com/palantir/go-githubapp v0.5.0 h1:mAdLgaaNV0zrqSv1q0zpJbKq65H92uIrAlSwRIRsGEE=
+github.com/palantir/go-githubapp v0.5.0/go.mod h1:/Xm5h66uEBX24An2Ln8H6Rk44z8uwk4E6m4gNrPadjQ=
 github.com/pkg/errors v0.8.1/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0=
 github.com/pkg/errors v0.9.1 h1:FEBLx1zS214owpjy7qsBeixbURkuhQAwrK5UwLGTwt4=
 github.com/pkg/errors v0.9.1/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0=

diff --git a/pull/github_context.go b/pull/github_context.go
@@ -19,7 +19,7 @@ import (
 	"fmt"
 	"net/http"
 
-	"github.com/google/go-github/v31/github"
+	"github.com/google/go-github/v32/github"
 	"github.com/pkg/errors"
 )
 

diff --git a/pull/pull_requests.go b/pull/pull_requests.go
@@ -18,7 +18,7 @@ import (
 	"context"
 	"fmt"
 
-	"github.com/google/go-github/v31/github"
+	"github.com/google/go-github/v32/github"
 	"github.com/pkg/errors"
 	"github.com/rs/zerolog"
 )

diff --git a/server/handler/base.go b/server/handler/base.go
@@ -17,7 +17,7 @@ package handler
 import (
 	"context"
 
-	"github.com/google/go-github/v31/github"
+	"github.com/google/go-github/v32/github"
 	"github.com/palantir/go-githubapp/githubapp"
 	"github.com/pkg/errors"
 	"github.com/rs/zerolog"

diff --git a/server/handler/check_run.go b/server/handler/check_run.go
@@ -18,7 +18,7 @@ import (
 	"context"
 	"encoding/json"
 
-	"github.com/google/go-github/v31/github"
+	"github.com/google/go-github/v32/github"
 	"github.com/palantir/go-githubapp/githubapp"
 	"github.com/pkg/errors"
 

diff --git a/server/handler/issue_comment.go b/server/handler/issue_comment.go
@@ -18,7 +18,7 @@ import (
 	"context"
 	"encoding/json"
 
-	"github.com/google/go-github/v31/github"
+	"github.com/google/go-github/v32/github"
 	"github.com/palantir/go-githubapp/githubapp"
 	"github.com/pkg/errors"
 

diff --git a/server/handler/pull_request.go b/server/handler/pull_request.go
@@ -18,7 +18,7 @@ import (
 	"context"
 	"encoding/json"
 
-	"github.com/google/go-github/v31/github"
+	"github.com/google/go-github/v32/github"
 	"github.com/palantir/go-githubapp/githubapp"
 	"github.com/pkg/errors"
 

diff --git a/server/handler/pull_request_review.go b/server/handler/pull_request_review.go
@@ -18,7 +18,7 @@ import (
 	"context"
 	"encoding/json"
 
-	"github.com/google/go-github/v31/github"
+	"github.com/google/go-github/v32/github"
 	"github.com/palantir/go-githubapp/githubapp"
 	"github.com/pkg/errors"
 

diff --git a/server/handler/push.go b/server/handler/push.go
@@ -18,7 +18,7 @@ import (
 	"context"
 	"encoding/json"
 
-	"github.com/google/go-github/v31/github"
+	"github.com/google/go-github/v32/github"
 	"github.com/palantir/go-githubapp/githubapp"
 	"github.com/pkg/errors"
 

diff --git a/server/handler/status.go b/server/handler/status.go
@@ -18,7 +18,7 @@ import (
 	"context"
 	"encoding/json"
 
-	"github.com/google/go-github/v31/github"
+	"github.com/google/go-github/v32/github"
 	"github.com/palantir/go-githubapp/githubapp"
 	"github.com/pkg/errors"
 

diff --git a/server/server.go b/server/server.go
@@ -97,8 +97,13 @@ func New(c *Config) (*Server, error) {
 			&handler.Status{Base: baseHandler},
 		},
 		c.Github.App.WebhookSecret,
+		githubapp.WithErrorCallback(githubapp.MetricsErrorCallback(base.Registry())),
 		githubapp.WithScheduler(
-			githubapp.QueueAsyncScheduler(queueSize, workers, githubapp.WithSchedulingMetrics(base.Registry())),
+			githubapp.QueueAsyncScheduler(
+				queueSize, workers,
+				githubapp.WithSchedulingMetrics(base.Registry()),
+				githubapp.WithAsyncErrorCallback(githubapp.MetricsAsyncErrorCallback(base.Registry())),
+			),
 		),
 	)
 

diff --git a/vendor/github.com/google/go-github/v31/github/actions_secrets.go b/vendor/github.com/google/go-github/v31/github/actions_secrets.go
diff --git a/...r/github.com/google/go-github/v31/AUTHORS → ...r/github.com/google/go-github/v32/AUTHORS b/...r/github.com/google/go-github/v31/AUTHORS → ...r/github.com/google/go-github/v32/AUTHORS
diff --git a/...r/github.com/google/go-github/v31/LICENSE → ...r/github.com/google/go-github/v32/LICENSE b/...r/github.com/google/go-github/v31/LICENSE → ...r/github.com/google/go-github/v32/LICENSE
diff --git a/...om/google/go-github/v31/github/actions.go → ...om/google/go-github/v32/github/actions.go b/...om/google/go-github/v31/github/actions.go → ...om/google/go-github/v32/github/actions.go
diff --git a/...go-github/v31/github/actions_artifacts.go → ...go-github/v32/github/actions_artifacts.go b/...go-github/v31/github/actions_artifacts.go → ...go-github/v32/github/actions_artifacts.go