Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positive detection when inside submodules #276

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

menehune23
Copy link

@menehune23 menehune23 commented Jul 14, 2023

Summary

Fails detection when .git is a file and not a folder.

Use Cases

Closes #275

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@arjun024
Copy link
Member

Hey Andrew 👋
Thanks for the PR. I'm wondering if the right thing to do is for the buildpack to still detect? (but accommodate submodules as well - like git rev-parse HEAD:path-to-sub-module instead of git rev-parse HEAD for example).

@paketo-buildpacks/utilities-maintainers I feel like the use case of extracting git metadata is valid for submodules just like root level git repos. WDYT?

@arjun024
Copy link
Member

@menehune23 And would a project.toml exclude give your issue some temporary relief until we figure out the right way to do it

@menehune23
Copy link
Author

@menehune23 And would a project.toml exclude give your issue some temporary relief until we figure out the right way to do it

Hey @arjun024, thanks for getting back about this! I do think that project.toml should help alleviate this for now, since the exclude field is respected by kpack (which is ultimately what is running our build).

Feel free to close this if y'all determine this isn't the right approach. Glad it's on the radar now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build fails if workspace is a submodule
2 participants