[Bug] Prevent battle skip with Wimp Out

[muscode13]

What are the changes the user will see?

Wimp Out triggering in a double battle shouldn't skip battles

Why am I making these changes?

Bug: https://discord.com/channels/1125469663833370665/1290778513363959941

What are the changes from a developer perspective?

Pokémon are prevented from taking damage if they're switching out or fleeing, via checks of Pokemon.switchOutStatus.

Checks also added to turn-end-phase.ts and weather-effect-phase.ts to prevent messages showing up for fled pokemon

Screenshots/Videos

Wimpod
https://github.com/user-attachments/assets/650fa836-bf52-4874-9369-ca8cc2f669af

Thundercage (Posturn effect)

thundercage.mp4

Toxic

toxic.mp4

Weather

weather.mp4

How to test the changes?

Double battle with Wimpods, target Right Wimpod with a priority move to make it flee, target both with a spread move. It shouldn't skip battles.

Checklist

• I'm using beta as my base branch
• There is no overlap with another PR?
• The PR is self-contained and cannot be split into smaller PRs?
• Have I provided a clear explanation of the changes?
• Have I tested the changes manually?
• Are all unit tests still passing? (npm run test)
  • Have I created new automated tests (npm run create-test) or updated existing tests related to the PR's changes?
• Have I provided screenshots/videos of the changes (if applicable)?
  • Have I made sure that any UI change works for both UI themes (default and legacy)?

Are there any localization additions or changes? If so:

• Has a locales PR been created on the locales repo?
  • If so, please leave a link to it here:
• Has the translation team been contacted for proofreading/translation?

[DayKev]

Couldn't you use Pokemon.switchOutStatus instead? From what I can tell it's supposed to be true when a Pokémon is switching out or fleeing.

[DayKev]

Seems fine to me, a simple fix. We still need a test added though.

[DayKev]

Just a couple test nits.

[muscode13]

@DayKev Added some more checks to turn-end-phase.ts and weather-effect-phase.ts to prevent messages showing up from weather, traps, etc. I've also attached new videos to show that. Let me know what you think!

[PigeonBar]

Based on a quick search for other places where updateAndDamage() is called, here are a few more edge cases that probably need a check for switchOutStatus:

PostWeatherLapseAbAttr (e.g., Dry Skin in harsh sun):

pokerogue/src/phases/weather-effect-phase.ts

Line 63 in de0d977

this.executeForAll((pokemon: Pokemon) => applyPostWeatherLapseAbAttrs(PostWeatherLapseAbAttr, pokemon, this.weather));

Flame Burst splash damage:

pokerogue/src/data/move.ts

Line 1850 in de0d977

targetAlly.damageAndUpdate(Math.max(1, Math.floor(1 / 16 * targetAlly.getMaxHp())), HitResult.OTHER);

Grass + Fire Pledge arena effect:

pokerogue/src/data/arena-tag.ts

Line 1152 in de0d977

pokemon.damageAndUpdate(toDmgValue(pokemon.getMaxHp() / 8));

Bad Dreams ability:

pokerogue/src/data/ability.ts

Line 3734 in de0d977

opp.damageAndUpdate(Utils.toDmgValue(opp.getMaxHp() / 8), HitResult.OTHER);

(There may be a cleaner approach than having to place switchOutStatus checks everywhere, but I'm not sure how to attempt something like that.)

[DayKev]

Based on a quick search for other places where updateAndDamage() is called, here are a few more edge cases that probably need a check for switchOutStatus:

Added checks in the mentioned places.

[MokaStitcher]

ugh, I managed to trigger a battle skip when testing, but i wasn't recording so i don't remember exactly how 😭
I'll try and do it again...

edit: Good news, I have it on tape. Bad news, the first time I did it it was a double battle, and the second time was a single battle...
(i've been using the override to switch between single and double battles though so maybe that doesn't help...)
I have also been testing with using multi hit moves so that may be part of the issue and wouldn't happen with the fix in #4935

[MokaStitcher]

pretty sure my issues when testing were related to multi hit moves as I couldn't reproduce them without. lgtm

[PigeonBar]

Time to find out what this green button does

[MokaStitcher]

Time to find out what this green button does

For a moment I thought you were talking about the merge button :D