[Bug] Fixed First Turn Move + Wimp Out interaction

[muscode13]

What are the changes the user will see?

Can now use Fake Out/First Impression if forced out

Why am I making these changes?

This is a reported bug: https://discord.com/channels/1125469663833370665/1308989093048225902/1308989093048225902

What are the changes from a developer perspective?

Added another || where pokemon.battleSummonData.turnCount and pokemon.battleSummonData.waveTurnCount are decremented for moves like U-Turn. It checks if the last pokemon has the PostDamageForceSwitchAbAttr ability attribute and that they are not fainted

Screenshots/Videos

wimpfiz.mp4

How to test the changes?

Use Fake Out after being forced out due to Wimp Out on turn 1

Checklist

• I'm using beta as my base branch
• There is no overlap with another PR?
• The PR is self-contained and cannot be split into smaller PRs?
• Have I provided a clear explanation of the changes?
• Have I tested the changes manually?
• Are all unit tests still passing? (npm run test)
  • Have I created new automated tests (npm run create-test) or updated existing tests related to the PR's changes?
• Have I provided screenshots/videos of the changes (if applicable)?
  • Have I made sure that any UI change works for both UI themes (default and legacy)?

Are there any localization additions or changes? If so:

• Has a locales PR been created on the locales repo?
  • If so, please leave a link to it here:
• Has the translation team been contacted for proofreading/translation?

[PigeonBar]

20241128.Fake.Out.Turn.2.mp4

This approach runs into an edge case where if you switch out a Wimp Out user before the battle starts, then Fake Out fails on Turn 1 and instead succeeds on Turn 2.

In the long run, we should probably change the implementation by adding another parameter to SwitchSummonPhase's constructor for whether or not the switch is happening mid-turn (e.g., u-turn, dragon tail, wimp out).

[DayKev]

20241128.Fake.Out.Turn.2.mp4
This approach runs into an edge case where if you switch out a Wimp Out user before the battle starts, then Fake Out fails on Turn 1 and instead succeeds on Turn 2.

In the long run, we should probably change the implementation by adding another parameter to SwitchSummonPhase's constructor for whether or not the switch is happening mid-turn (e.g., u-turn, dragon tail, wimp out).

Hmm, I wonder if there's an easy way to work around this for now.