Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Audio] Replace Forest track with custom BGM by Andr06 #4924

Open
wants to merge 3 commits into
base: beta
Choose a base branch
from

Conversation

Madmadness65
Copy link
Collaborator

@Madmadness65 Madmadness65 commented Nov 20, 2024

What are the changes the user will see?

The Forest biome's music track will be replaced with Andr06's custom track, Rogue's Echoes.

Why am I making these changes?

Custom biome music is desired.

What are the changes from a developer perspective?

Replaced audio file and altered loop point. Localization changes will also be handled in the locale repository.

Screenshots/Videos

forest.mp4

How to test the changes?

Go to the Forest biome.

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes manually?
  • Are all unit tests still passing? (npm run test)
    • [N/A ] Have I created new automated tests (npm run create-test) or updated existing tests related to the PR's changes?
  • Have I provided screenshots/videos of the changes (if applicable)?
    • [N/A] Have I made sure that any UI change works for both UI themes (default and legacy)?

Are there any localization additions or changes? If so:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Audio Relates to the SFX or BGM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant