Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI/UX][QOL] Add number of eggs hatching to egg skip prompt #4913

Merged
merged 1 commit into from
Nov 30, 2024

Conversation

Fontbane
Copy link
Contributor

@Fontbane Fontbane commented Nov 18, 2024

What are the changes the user will see?

  • If the egg skip option is set to "Ask", the prompt will say how many eggs are about to hatch

Why am I making these changes?

  • Small QoL
  • The user might decide differently if they know only 6 eggs are hatching rather than 20

What are the changes from a developer perspective?

  • This PR simply passes the eggsToHatchCount variable from EggLapsePhase as an argument when the eggSkipPrompt locale entry is called, as eggsToHatch

Screenshots/Videos

image

How to test the changes?

  • Add {{eggsToHatch}} somewhere in the eggSkipPrompt entry in a battle.json translation file, or check out the linked translation PR

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I considered writing automated tests for the issue?
  • If I have text, did I make it translatable and add a key in the English locale file(s)?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@Fontbane Fontbane requested a review from a team as a code owner November 18, 2024 23:36
@DayKev DayKev added UI/UX User interface/-experience related Awaiting Locales This PR makes changes to existing locales and requires further review labels Nov 18, 2024
@DayKev DayKev merged commit 6733d81 into pagefaultgames:beta Nov 30, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Locales This PR makes changes to existing locales and requires further review UI/UX User interface/-experience related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants