Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilize request pieces from common.proto in PactConsumerTest request #7

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jarmy
Copy link

@jarmy jarmy commented Sep 15, 2022

This illustrates a situation where a proto file (area_calculator.proto) imports another proto (common.proto) which is used in the request specified by PactConsumerTest

        "request", Map.of(
          "device_context", Map.of(
              "device_id", "matching(number, 4)",
              "carrier_name", "matching(type, 'foo')"
          )),
          "listener_context", Map.of(
              "listener_id", "matching(number, 1)"
          ),

@YOU54F
Copy link
Member

YOU54F commented May 16, 2024

Hey, thanks for the example however it may be best as a separate example, or possible an extension of the test_enums example

https://github.com/pact-foundation/pact-plugins/tree/main/examples/gRPC/test_enums

as the area_calculator example is canonical and used in multiple languages, changing only one example has negative implications.

We would certainly be interested in more complex examples, as I appreciate some of these are somewhat naive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants