upgrade to gradle 8 #63
Conversation
|
just pushed under a branch on origin, to see if some of the failures are reltaed to being from an outside PR https://github.com/pact-foundation/pact-plugins/tree/austek-gradle_8 |
that build only failed because of some Github limits
|
|
Yeah they get me everytime if I raise a PR which has a branch on origin, as you get two sets of jobs, and they all publish unit test results back. We should probably update that to not allow it to fail the build, if we are hitting limits. re-triggered job and they've passed now Thanks for the change @austek. I'll add Ron as a reviewer as well, but I shall give it an approve |
|
I think to get this merged you may want to at least b) a) squash your commits Apart from that looks good to me, but I don't often test the consumption of the jvm-driver in pact-jvm so unsure if this may cause an issue for consumers of the jvm-driver |
|
ty Ali! |
drivers/jvm/build.gradle
Outdated
| @@ -26,8 +24,8 @@ subprojects { | |||
|
|
|||
| version = '0.4.3' | |||
|
|
|||
| targetCompatibility = '11' | |||
There was a problem hiding this comment.
Again, this needs to be able to run on JDK 11
There was a problem hiding this comment.
au.com.dius.pact.core:support:4.6.9 is not compatible with JDK 11
There was a problem hiding this comment.
Yes, we will have to use 4.5.9
| id 'groovy' | ||
| } | ||
|
|
||
| version = '0.0.0' | ||
| targetCompatibility = '11' | ||
| sourceCompatibility = '11' | ||
| targetCompatibility = '17' |
There was a problem hiding this comment.
does this need to be 11 here with 4.5.x branch of pact-jvm?
|
@rholshausen is this something you'd like to get merged, if not, I'll close the PR |
|
Hmm has this already been cherry picked here in master |
|
I thought I modified the PR and then merged. But I guess it is see it as a new commit and still labels it as unmerged. |
|
Tres bizarre! Thanks @rholshausen and @austek 💛 |
upgrade to gradle 8
upgrade depencies