Keep registration order as order for context menu #163
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #147
I kept
_categories
and_registeredModelsCategory
as-is. Someone could've called those functions and stored the variables, and removing them, but especially replacing it with a new data-type, would break their code (replacing could silently break in some cases). My ideal would've been to just change thecategories()
function to return thestd::vector
and to change theregisteredModelsCategoryAssociation
to return a separate map type that preserves insertion order (similar to LinkedHashMap in Java; I would've just combinedstd::vector
andstd::unordered_map
).If removing / changing
_categories
or_registeredModelsCategory
is desired, I'll make the change and update this PR.Note: if we do remove
categories()
, such that_categories
becomes inaccessible through any external functions, it'd be best to change its type fromstd::set
tostd::unordered_set