Add support for new platform property annotations for P4Runtime. #4611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
p4lang/p4runtime#472 has been merged. Is this PR ready for review? |
jonathan-dilorenzo
changed the title
jonathan-dilorenzo
changed the title
fruffy
reviewed
May 30, 2024
fruffy
approved these changes
May 30, 2024
smolkaj
approved these changes
May 31, 2024
| @platform_property( | ||
| multicast_group_table_size = 10, | ||
| multicast_group_table_total_replicas = 20, | ||
| multicast_group_table_max_replicas_per_entry = 30 |
There was a problem hiding this comment.
It would be really wonderful (but certainly not a blocker) if we could support optional, trailing commas here.
There was a problem hiding this comment.
Agreed, but I believe not currently how the KV parser works, which I just call without modification. @fruffy might know better though?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See this PR for more information: p4lang/p4runtime#472