Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roll down parent inheritance recursively #14

Merged
merged 18 commits into from
Oct 1, 2024
Merged

Conversation

sneakers-the-rat
Copy link
Contributor

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10843710178

Details

  • 27 of 36 (75.0%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.5%) to 89.626%

Changes Missing Coverage Covered Lines Changed/Added Lines %
nwb_linkml/src/nwb_linkml/adapters/namespaces.py 17 26 65.38%
Files with Coverage Reduction New Missed Lines %
nwb_linkml/src/nwb_linkml/maps/dtype.py 1 96.77%
Totals Coverage Status
Change from base Build 10824130206: -0.5%
Covered Lines: 2324
Relevant Lines: 2594

💛 - Coveralls

…ing attributes in nested inheritance, and the models are now extremely noisy, creating the same fields over and over even when they aren't overridden or modified by the child class. Need to redo the rolldown, make it less generic, don't dump to dicts, merge in a more targeted way.
…till funny in patchclampseries children w.r.t. losing attributes in data
…e_value, try to pass the input as the ``value`` field of the model. fix test assumptions and model creation.

model update to follow
@sneakers-the-rat sneakers-the-rat marked this pull request as ready for review September 26, 2024 08:28
@sneakers-the-rat sneakers-the-rat merged commit ae37db3 into main Oct 1, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants