Skip to content
This repository has been archived by the owner on Aug 26, 2022. It is now read-only.

Cycle detection optimizations #224

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

t-rasmud
Copy link
Contributor

Check for cycles only at Sends

@paulthomson
Copy link
Contributor

Personally, I would have not added a bool to GetNext. Instead, just check the operation type inside the cycledetector strategy. Unless there is an issue with doing this?

BugFindingRuntime.cs has essentially no changes, so should be reverted (unless GitHub is just not showing them).

When I tried to make this change, I struggled because the cycle detector uses the trace of operations and it assumes that trace.count - 2 (or something like that) will be the last operation and that this operation has a state hash. But this is no longer the case. I think you will need to take this into account.

This was my attempt:
5c0f2f1

@pdeligia
Copy link
Contributor

Thanks guys! I will check these stuff out!

@pdeligia pdeligia changed the title Cycledetectionoptimizations Cycle detection optimizations Jul 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants