Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace toustui editor with md editor #12156

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Conversation

LukasHirt
Copy link
Collaborator

@LukasHirt LukasHirt commented Feb 4, 2025

Description

The original lib used in the text editor component is having CVE but is no longer maintained. Since we do not wish to maintain a fork of the lib, we decided to replace it. This brings in https://github.com/imzbf/md-editor-v3

Related Issue

Motivation and Context

No CVE === secure oCIS

How Has This Been Tested?

  • test environment: chrome & firefox
  • test case 1: open text editor to edit .txt file
  • test case 2: open text editor to edit .md file
  • test case 3: open space and see & edit description
  • test case 4: open app in app store and see description

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Open tasks:

  • fix errors with codemirror when running dev server
  • add changelog
  • fix tests

@CLAassistant
Copy link

CLAassistant commented Feb 5, 2025

CLA assistant check
All committers have signed the CLA.

@owncloud owncloud deleted a comment from update-docs bot Feb 5, 2025
@LukasHirt LukasHirt marked this pull request as ready for review February 5, 2025 08:53
@LukasHirt LukasHirt force-pushed the feat/replace-md-editor branch from 1b1a4ee to a976bac Compare February 5, 2025 08:56
@LukasHirt LukasHirt requested a review from mzner February 5, 2025 08:57
@LukasHirt LukasHirt self-assigned this Feb 5, 2025
@LukasHirt LukasHirt added the Type:Bug Something isn't working label Feb 5, 2025
@mzner mzner force-pushed the feat/replace-md-editor branch from a976bac to 17e07e9 Compare February 5, 2025 09:19
@LukasHirt LukasHirt force-pushed the feat/replace-md-editor branch from 17e07e9 to b4aa238 Compare February 5, 2025 09:28
The original lib used in the text editor component is having CVE but is no longer maintained. Since we do not wish to maintain a fork of the lib, we decided to replace it. This brings in https://github.com/imzbf/md-editor-v3

Co-authored-by: mzner <[email protected]>
@LukasHirt LukasHirt force-pushed the feat/replace-md-editor branch from b4aa238 to 93e0b2f Compare February 5, 2025 09:52
@LukasHirt LukasHirt enabled auto-merge February 5, 2025 09:54
Copy link

sonarqubecloud bot commented Feb 5, 2025

@LukasHirt LukasHirt merged commit ae2f272 into master Feb 5, 2025
4 checks passed
@LukasHirt LukasHirt deleted the feat/replace-md-editor branch February 5, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type:Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants