[tests-only] accessibility test for basic functionalities of file view #12155
+587
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
…ns for single exclude and 2 exclude
koebel
changed the title
Comment on lines
+54
to
+56
| // excluded for known accessibility issues | ||
| // selectors.resourceTableEditName --> buttons must have discernible text | ||
| // selectors.resourceIconLink --> buttons/links must have discernible text |
There was a problem hiding this comment.
need to decide how to track those issues that we skip here, if developers fix them I doubt that they will remember to change the test
| async function (this: World, stepUser: string): Promise<void> { | ||
| const { page } = this.actorsEnvironment.getActor({ key: stepUser }) | ||
|
|
||
| const a11yObject = new objects.a11y.Accessibility({ page }) |
There was a problem hiding this comment.
confused about the name of the pageObject
|
…e exclude or array with multiple excludes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
setup axe core and implementation of most important accessibility tests for file view
Related Issue
Motivation and Context
make sure that oCIS web is compliant with the WCAG accessibility standards
As a user with limited accessibility
I want to be able to access all features of oCIS
So that regardless of my abilities and circumstances, I can benefit from oCIS
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Open tasks: