Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(password-protected-folders): create folder in the personal space #12146

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LukasHirt
Copy link
Collaborator

Description

Create the hidden folder in users personal space

Related Issue

Motivation and Context

Other users cannot access the folder without the pass

How Has This Been Tested?

  • test environment: chrome & 🤖
  • test case 1: Create a password protected folder in users personal space
  • test case 2: Create a password protected folder in created space

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

@LukasHirt LukasHirt added the Type:Bug Something isn't working label Jan 30, 2025
@LukasHirt LukasHirt requested a review from saw-jan January 30, 2025 11:13
@LukasHirt LukasHirt self-assigned this Jan 30, 2025
@LukasHirt LukasHirt force-pushed the fix/psec-folder-location branch from ec23448 to fe726bd Compare February 3, 2025 09:59
Copy link

sonarqubecloud bot commented Feb 3, 2025

@@ -26,20 +27,22 @@ export const useCreateFileHandler = () => {
}

const folderPath = '/.' + fileName
const folder = await clientService.webdav.createFolder(personalSpace, { path: folderPath })
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this mean if a protected folder is created in any project space, the folder (hidden folder) will be created in the creator's personal space?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also if I create test1 folder in my personal space. and try to create test1 in project space, it doesn't allow creation of test1 in the project space.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type:Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants